Reviewing files that changed from the base of the PR and between e5a815a and 43ba76b.

• app/migrated_routes/category.py (5 hunks)
• tests/test_relationships.py (2 hunks)

Reviewing files that changed from the base of the PR and between e5a815a and 43ba76b.

• app/migrated_routes/category.py (5 hunks)
• tests/test_relationships.py (2 hunks)

app/migrated_routes/category.py (3)

105-116: Postgres 409 path unreachable; compare against resolved DB constraint names and re‑raise correctly

Comparing to CategoryCollection._NAME_UNIQUE_CONSTRAINT.name won’t match Postgres’ actual constraint (e.g., category_name_key). Also prefer bare raise to preserve traceback. This mirrors an earlier review note.

         try:
             db.session.add(category)
             db.session.commit()
         except IntegrityError as ie:
             db.session.rollback()
-            if (
-                isinstance(ie.orig, UniqueViolation)
-                and ie.orig.diag.constraint_name
-                == CategoryCollection._NAME_UNIQUE_CONSTRAINT.name
-            ):
+            if (
+                isinstance(getattr(ie, "orig", None), UniqueViolation)
+                and getattr(getattr(ie.orig, "diag", None), "constraint_name", None)
+                in CategoryCollection._resolve_name_unique_constraint_names()
+            ):
                 abort(409, message="Category with this name already exists")
-            raise ie
+            raise

---

203-214: Duplicate link 409 path also unreachable on Postgres; resolve PK name via inspector and use bare re‑raise

category_subcategory.primary_key.name is typically None unless explicitly named; Postgres reports something like category_subcategory_pkey. Resolve it from the DB and compare against diag.constraint_name. This mirrors an earlier review note.

         try:
             db.session.commit()
         except IntegrityError as ie:
             db.session.rollback()
-            if (
-                isinstance(ie.orig, UniqueViolation)
-                and ie.orig.diag.constraint_name
-                == category_subcategory.primary_key.name
-            ):
-                abort(409, message="Category and subcategory already linked")
-            raise ie
+            if isinstance(getattr(ie, "orig", None), UniqueViolation):
+                pk_name = category_subcategory.primary_key.name
+                if not pk_name:
+                    pk_info = inspect(db.engine).get_pk_constraint(category_subcategory.name)
+                    pk_name = pk_info.get("name")
+                if getattr(getattr(ie.orig, "diag", None), "constraint_name", None) == pk_name:
+                    abort(409, message="Category and subcategory already linked")
+            raise

---

315-317: Approve code changes: relationship-based filtering reads clearly; nested any() is idiomatic, and the category_subcategory table already defines a composite primary key on (category_id, subcategory_id), supporting FKs, plus an index.

Reviewing files that changed from the base of the PR and between e5a815a and 43ba76b.

• app/migrated_routes/category.py (5 hunks)
• tests/test_relationships.py (2 hunks)

app/migrated_routes/category.py (3)

31-43: Import-time TypeError: staticmethod invoked inside the class body

At Line 42 you call _get_name_unique_constraint() while the class body is still executing. Because Line 31 decorates it with @staticmethod, the name in the class namespace is a staticmethod descriptor, so CategoryCollection fails to import with TypeError: 'staticmethod' object is not callable. Beyond that, caching the ORM UniqueConstraint instance won’t help you match the runtime constraint name on Postgres anyway (it stays None when the column was declared with unique=True). Please replace this with a lazily evaluated inspector-based helper that returns the real constraint names.

-from sqlalchemy import UniqueConstraint, exists
+from functools import lru_cache
+from sqlalchemy import UniqueConstraint, exists, inspect
...
-    @staticmethod
-    def _get_name_unique_constraint():
-        name_col = Category.__table__.c.name
-        return next(
-            con
-            for con in Category.__table__.constraints
-            if isinstance(con, UniqueConstraint)
-            and len(con.columns) == 1
-            and con.columns.contains_column(name_col)
-        )
-
-    _NAME_UNIQUE_CONSTRAINT = _get_name_unique_constraint()
+    @staticmethod
+    @lru_cache(maxsize=1)
+    def _name_unique_constraint_names():
+        insp = inspect(db.engine)
+        return tuple(
+            uc["name"]
+            for uc in insp.get_unique_constraints(Category.__tablename__)
+            if uc.get("name") and set(uc.get("column_names") or []) == {"name"}
+        )

---

105-116: Duplicate-name 409 branch is still unreachable on Postgres

Line 113 compares ie.orig.diag.constraint_name against _NAME_UNIQUE_CONSTRAINT.name, but—as noted previously—that attribute is None for constraints produced by Column(unique=True). In Postgres the driver reports category_name_key, so this equality never succeeds and we still leak the IntegrityError as a 500. After adopting the inspector helper above, rework this block to compare against the resolved constraint names (use getattr to guard against engines that lack .diag). Also re-raise with bare raise to preserve the original traceback.

-            if (
-                isinstance(ie.orig, UniqueViolation)
-                and ie.orig.diag.constraint_name
-                == CategoryCollection._NAME_UNIQUE_CONSTRAINT.name
-            ):
+            constraint_name = getattr(getattr(ie.orig, "diag", None), "constraint_name", None)
+            if (
+                isinstance(ie.orig, UniqueViolation)
+                and constraint_name in CategoryCollection._name_unique_constraint_names()
+            ):
                 abort(409, message="Category with this name already exists")
-            raise ie
+            raise

---

203-213: Association duplicate guard never fires because the PK name is None

category_subcategory.primary_key.name (Line 210) returns None unless the association table’s primary key was explicitly named—Postgres emits category_subcategory_pkey, so this branch is dead and the update endpoint still returns 500. Resolve the actual PK name via inspect(db.engine).get_pk_constraint(category_subcategory.name)["name"] (cache it) and compare against that result. Guard access to .diag just like in the name-constraint case, and use bare raise afterward.

-            if (
-                isinstance(ie.orig, UniqueViolation)
-                and ie.orig.diag.constraint_name
-                == category_subcategory.primary_key.name
-            ):
+            pk_name = category_subcategory.primary_key.name
+            if not pk_name:
+                pk_name = inspect(db.engine).get_pk_constraint(category_subcategory.name)["name"]
+            constraint_name = getattr(getattr(ie.orig, "diag", None), "constraint_name", None)
+            if isinstance(ie.orig, UniqueViolation) and constraint_name == pk_name:
                 abort(409, message="Category and subcategory already linked")
-            raise ie
+            raise

Reviewing files that changed from the base of the PR and between 43ba76b and 819a812.

• app/migrated_routes/category.py (5 hunks)

app/migrated_routes/category.py (2)

315-317: LGTM: Relationship-based filtering is clearer than manual joins.

This reads well and should generate efficient EXISTS subqueries with proper FK/PK indexes.

---

31-42: Blocker: @staticmethod call inside class body is not callable (TypeError at import time).

Calling a @staticmethod within the class body invokes the staticmethod descriptor, which isn’t callable and raises at import time. Call the underlying function via .__func__ (or move the assignment after the class definition).

Apply:

-    _NAME_UNIQUE_CONSTRAINT = _get_name_unique_constraint()
+    _NAME_UNIQUE_CONSTRAINT = _get_name_unique_constraint.__func__()

Likely an incorrect or invalid review comment.